Fix PR #70 review comments: pin action SHA, reject whitespace-only names#71
Closed
Fix PR #70 review comments: pin action SHA, reject whitespace-only names#71
Conversation
- Add concurrency block to cancel stale runs - Add format and lint jobs (repo-specific tooling) - Gate test/build on format+lint passing - Add PR docker-build job with Trivy vulnerability scan - Align job structure with Go/Node.js/Python pattern
- Pin trivy-action from @master to @0.24.0 for supply-chain safety - Guard SARIF upload to same-repo PRs only (fixes fork permission issue) - Remove [InlineData(" ")] from name validation test: [Required] does not reject whitespace-only strings, making that case incorrect - Replace Substring(0, 5) with Guid.NewGuid().ToString("N")[..5] in AutoFixture customizations to eliminate flaky ArgumentOutOfRangeException
…ops-thiago/otel-core-example into copilot/fix-checks-and-address-comments
…espace validation Co-authored-by: devops-thiago <2332561+devops-thiago@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing checks and address comments in PR #70
Fix PR #70 review comments: pin action SHA, reject whitespace-only names
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #70 had unresolved review comments around supply-chain security for unpinned GitHub Actions and a validation gap allowing whitespace-only user names to pass
[Required].Changes
ci.yml): Pindocker/build-push-actionin thedocker-buildjob to commit SHA (10e90e3...) matching what thedocker-publishjob already uses — eliminates the mutable@v6tag referenceUserDto.cs): Add[RegularExpression(@".*\S.*")]toCreateUserDto.Name—[Required]alone accepts" "as valid; the regex enforces at least one non-whitespace characterUserDtoValidationTests.cs): Add[InlineData(" ")]toCreateUserDto_WithInvalidName_ShouldFailValidationto assert the new validation rule✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.